Attempting to fix up the issue related to artifactory download in the tnctl create revision command,

We had a bug in the code which was cause issues with direct http calls.

-       if strings.HasPrefix(source, "http") {
-               source = strings.TrimPrefix(source, "http://")
-               source = strings.TrimPrefix(source, "https://")

This has been removed.

The main issue however was found when dealing with Artifactory assets, using the follow example.

bin/tnctl create revision https://USERNAME:[email protected]/artifactory/art-terraform-modules-local/kash/rds/aws/1.0.0 -f test.yaml

We are getting a 404. Adding a .zip to the URL i.e. /kash/rds/aws/1.0.0.zip allowed us to download the zip file. I’m guessing we are missing a headers information which artifactory requires.

The second issue comes from the fact that zip is downloaded, BUT extracted into a subfolder in the destination directory - i’ve confirmed the same bahavior when using go-getter binary directory

ls /tmp/test-download
 .   ..   terraform-aws-rds

In the URL for the revision we fix this by adding the submodule path i.e.

bin/tnctl create revision https://USERNAME:[email protected]/artifactory/art-terraform-modules-local/kash/rds/aws/1.0.0.zip//terraform-aws-rds -f test.yaml

I’m guessing terraform most be doing something outside of the go-getter li to fix this.